Bug 111020 - Plumb wasFetchedViaQUIC() into WebKit.
Summary: Plumb wasFetchedViaQUIC() into WebKit.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-27 15:37 PST by Ryan Hamilton
Modified: 2013-02-27 16:52 PST (History)
0 users

See Also:


Attachments
Patch (7.19 KB, patch)
2013-02-27 15:37 PST, Ryan Hamilton
fishd: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hamilton 2013-02-27 15:37:03 PST
Plumb wasFetchedViaQUIC() into WebKit.
Comment 1 Ryan Hamilton 2013-02-27 15:37:26 PST
Created attachment 190620 [details]
Patch
Comment 2 Darin Fisher (:fishd, Google) 2013-02-27 16:20:06 PST
Comment on attachment 190620 [details]
Patch

This doesn't need to be here.  "wasFetchedViaSPDY" should also be removed.  We can put these on the ExtraData object that the embedder gets to define.  WebCore and WebKit don't need to know anything about SPDY or QUIC.
Comment 3 Ryan Hamilton 2013-02-27 16:52:51 PST
(In reply to comment #2)
> (From update of attachment 190620 [details])
> This doesn't need to be here.  "wasFetchedViaSPDY" should also be removed.  We can put these on the ExtraData object that the embedder gets to define.  WebCore and WebKit don't need to know anything about SPDY or QUIC.

I do not know enough about WebKit to fully appreciate the ramifications of what you are proposing.  Since we have extensions and existing JS code which expects to be able to read window.chrome.window.chrome.loadTimes().wasFetchedViaSpdy, it is desirable to maintain this interface.  Are you proposing that we change the interface, or does ExtraData provide a different mechanism to populate the existing interface.  Can you point me at an example?