Bug 111017 - [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
Summary: [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on: 111113 111146
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-27 15:01 PST by James Robinson
Modified: 2013-02-28 23:42 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.52 KB, patch)
2013-02-27 15:03 PST, James Robinson 		no flags Details | Formatted Diff | Diff
rejigger WebTestProxyBase to avoid WebViewClient indirection (4.75 KB, patch)
2013-02-27 15:58 PST, James Robinson 		abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-02-27 15:01:44 PST 
[chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
Comment 1 James Robinson 2013-02-27 15:03:15 PST 
Created attachment 190612 [details]
Patch
Comment 2 James Robinson 2013-02-27 15:04:32 PST 
This is a bit insane but seems to work.  Depends on https://codereview.chromium.org/12330184/ landing + rolling in or this won't compile.
Comment 3 WebKit Review Bot 2013-02-27 15:07:17 PST 
Comment on attachment 190612 [details]
Patch

Attachment 190612 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16802164
Comment 4 WebKit Review Bot 2013-02-27 15:14:59 PST 
Comment on attachment 190612 [details]
Patch

Attachment 190612 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16795169
Comment 5 James Robinson 2013-02-27 15:58:53 PST 
Created attachment 190624 [details]
rejigger WebTestProxyBase to avoid WebViewClient indirection
Comment 6 WebKit Review Bot 2013-02-27 16:11:48 PST 
Comment on attachment 190624 [details]
rejigger WebTestProxyBase to avoid WebViewClient indirection

Attachment 190624 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16793166
Comment 7 WebKit Review Bot 2013-02-27 16:16:11 PST 
Comment on attachment 190624 [details]
rejigger WebTestProxyBase to avoid WebViewClient indirection

Attachment 190624 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16817260
Comment 8 WebKit Review Bot 2013-02-27 20:28:38 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 9 jochen 2013-02-27 22:21:44 PST 
Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl)
Comment 10 Peter Beverloo (cr-android ews) 2013-02-28 07:16:37 PST 
Comment on attachment 190624 [details]
rejigger WebTestProxyBase to avoid WebViewClient indirection

Attachment 190624 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16802277
Comment 11 James Robinson 2013-02-28 11:02:09 PST 
(In reply to comment #9)
> Any idea how to implement this in content shell (where WebViewHost is RenderViewImpl)

There's no need to AFAIK. In content shell, the compositor embedding is handled by content::RenderWidget which uses content::RenderWidgetCompositor to deal with all of this.
Comment 12 James Robinson 2013-02-28 16:52:33 PST 
Committed r144398: <http://trac.webkit.org/changeset/144398>