Bug 111013 - check-webkit-style should not check within SHADER(...) macros
Summary: check-webkit-style should not check within SHADER(...) macros
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P4 Normal
Assignee: Michelangelo De Simone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-27 14:45 PST by Michelangelo De Simone
Modified: 2014-03-02 09:20 PST (History)
2 users (show)

See Also:

Attachments
Simple example (1.08 KB, patch)
2013-03-29 10:01 PDT, Michelangelo De Simone 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michelangelo De Simone 2013-02-27 14:45:40 PST 
We often use SHADER(..) macros in CSS CustomFilters; this macro wraps GLSL code which does not necessarily follows the same convention we have in C++.
Comment 1 Michelangelo De Simone 2013-03-29 10:01:05 PDT 
Created attachment 195757 [details]
Simple example
Comment 2 Michelangelo De Simone 2013-03-29 10:02:52 PDT 
Comment on attachment 195757 [details]
Simple example

Adding a shader function such as "css_StyleTestDummyFunction" within a SHADER() macro triggers the style-checker with the following error:

css_StyleTestDummyFunction is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]