Bug 111006 - [BlackBerry] Disable auto-filling password in forms when auto-form-filling is not enabled.
Summary: [BlackBerry] Disable auto-filling password in forms when auto-form-filling is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Lyon Chen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-27 13:12 PST by Lyon Chen
Modified: 2013-02-28 07:19 PST (History)
7 users (show)

See Also:

Attachments
patch for 111006 (2.54 KB, patch)
2013-02-27 13:47 PST, Lyon Chen 		no flags Details | Formatted Diff | Diff
Updated patch with internal PR info (2.61 KB, patch)
2013-02-27 13:57 PST, Lyon Chen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lyon Chen 2013-02-27 13:12:55 PST 
Before we would never save user credential when auto-form-fill is not enabled. But that prevents us from saving user credential for http authentication. To fix this http authentication issue, we now allow saving user credential even when auto-form-fill is not enabled. But right now there are 2 places that will auto fill form when user credential is saved, we need to fix that.

These 2 places are:
* FrameLoaderClientBlackBerry::dispatchDidFinishLoad()
* FrameLoaderClientBlackBerry::dispatchWillSendSubmitEvent().

These 2 places need to be fixed so there will be no auto password filling when auto-form-fill is disabled.
Comment 1 Lyon Chen 2013-02-27 13:47:38 PST 
Created attachment 190596 [details]
patch for 111006
Comment 2 Lyon Chen 2013-02-27 13:57:35 PST 
Created attachment 190598 [details]
Updated patch with internal PR info
Comment 3 WebKit Review Bot 2013-02-28 07:19:06 PST 
Comment on attachment 190598 [details]
Updated patch with internal PR info

Clearing flags on attachment: 190598

Committed r144309: <http://trac.webkit.org/changeset/144309>
Comment 4 WebKit Review Bot 2013-02-28 07:19:09 PST 
All reviewed patches have been landed.  Closing bug.