Right now user credential is not correctly handled, like: * User credentials are never deleted from CertMgr; * User credentials are not always correctly saved/retrieved; * User credentials for http proxy are not re-used when visiting different sites. The reason are: * For the first one, CertMgrWrapper didn't support removing password before, but it has since been fixed and we need to use the new API to delete user credential from CertMgr. *For the second one, we treat encrypted text as normal text, but in fact they are just binary data, we need to treat them correctly, as binary data. * Fot the third one, we used to save user credential combined the original url, we should not.
Created attachment 190561 [details] patch for 110994
Comment on attachment 190561 [details] patch for 110994 r+ based on leo's review
Comment on attachment 190561 [details] patch for 110994 Clearing flags on attachment: 190561 Committed r144229: <http://trac.webkit.org/changeset/144229>
All reviewed patches have been landed. Closing bug.
Created attachment 190667 [details] Fix utf8 handling WTF::String::utf8 no longer receives a bool, see bug 101678. http://trac.webkit.org/changeset/134173/trunk/Source/WTF/wtf/text/WTFString.h
Should this bug be reopened?
(In reply to comment #6) > Should this bug be reopened? Thanks for reminding me of this change, it seems our repo had not synced with upstream for quite a while now. Re-open this for a new patch to adapt to the WTF::String::utf8() interface change.
(In reply to comment #5) > Created an attachment (id=190667) [details] > Fix utf8 handling > > WTF::String::utf8 no longer receives a bool, see bug 101678. > > http://trac.webkit.org/changeset/134173/trunk/Source/WTF/wtf/text/WTFString.h The patch looks good to me.
Comment on attachment 190667 [details] Fix utf8 handling Clearing flags on attachment: 190667 Committed r144316: <http://trac.webkit.org/changeset/144316>