Bug 110988 - [CSS Grid Layout] Add parsing for grid-{start|before}
Summary: [CSS Grid Layout] Add parsing for grid-{start|before}
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 103314
  Show dependency treegraph
 
Reported: 2013-02-27 09:10 PST by Julien Chaffraix
Modified: 2013-03-04 15:09 PST (History)
11 users (show)

See Also:


Attachments
Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start|end}. (39.82 KB, patch)
2013-02-27 09:23 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff
Proposed implementation 2: Same as 1, without the wrong test rebaselines. (36.64 KB, patch)
2013-02-27 11:23 PST, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-02-27 09:10:51 PST
As discussed in bug 110777, in order to support spanning and to properly parse the shorthands grid-{row|column}. We need to support and switch our internal representation to using grid-{start|end} instead of the current design which is based on grid-{row|column}.
Comment 1 Julien Chaffraix 2013-02-27 09:23:03 PST
Created attachment 190541 [details]
Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start|end}.
Comment 2 WebKit Review Bot 2013-02-27 10:59:57 PST
Comment on attachment 190541 [details]
Proposed implementation 1: Added the properties and refactored the internal to be aligned with grid-{start|end}.

Attachment 190541 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16675178

New failing tests:
svg/css/getComputedStyle-basic.xhtml
fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
Comment 3 Julien Chaffraix 2013-02-27 11:23:55 PST
Created attachment 190562 [details]
Proposed implementation 2: Same as 1, without the wrong test rebaselines.
Comment 4 WebKit Review Bot 2013-03-04 15:09:51 PST
Comment on attachment 190562 [details]
Proposed implementation 2: Same as 1, without the wrong test rebaselines.

Clearing flags on attachment: 190562

Committed r144681: <http://trac.webkit.org/changeset/144681>
Comment 5 WebKit Review Bot 2013-03-04 15:09:56 PST
All reviewed patches have been landed.  Closing bug.