Bug 110967 - Add calendar header for new calendar picker
Summary: Add calendar header for new calendar picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks: 109439
  Show dependency tree / graph
 
Reported: 2013-02-27 04:01 PST by Keishi Hattori
Modified: 2013-02-28 05:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (11.91 KB, patch)
2013-02-27 04:14 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (12.03 KB, patch)
2013-02-28 04:43 PST, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2013-02-27 04:01:05 PST 
Add calendar header for new calendar picker
Comment 1 Keishi Hattori 2013-02-27 04:14:06 PST 
Created attachment 190490 [details]
Patch
Comment 2 Kent Tamura 2013-02-27 06:30:41 PST 
Comment on attachment 190490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190490&action=review

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1925
> +/**
> + * @return {!boolean}
> + */
> +MonthPopupButton.prototype._shouldUseShortMonth = function(maxWidth) {

Need @param for maxWidth.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:1974
> +CalendarNavigationButton.DefaultrepeatingClicksStartingThreshold = 600;
> +CalendarNavigationButton.DefaultRepeatingClicksInterval = 300;

Ideally, these values should be synchronized with RenderTheme::initialAutoscrollTimerDelay and autoscrollTimerDelay.
You might want to change so later.

> Source/WebCore/Resources/pagepopups/calendarPicker.js:2096
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().previous(), true);
> +    else if (sender === this._nextMonthButton)
> +        this.calendarPicker.setCurrentMonth(this.calendarPicker.currentMonth().next(), true);

boolean argument isn't good.
Comment 3 Keishi Hattori 2013-02-28 04:43:29 PST 
Created attachment 190704 [details]
Patch
Comment 4 WebKit Review Bot 2013-02-28 05:07:53 PST 
Comment on attachment 190704 [details]
Patch

Clearing flags on attachment: 190704

Committed r144298: <http://trac.webkit.org/changeset/144298>
Comment 5 WebKit Review Bot 2013-02-28 05:08:03 PST 
All reviewed patches have been landed.  Closing bug.