[chromium] Introduce WebHyphenator class to consolidate hyphenation related method on WebKit::Platform
Created attachment 190457 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Created attachment 190482 [details] Patch
chromium side here: https://codereview.chromium.org/12335128/
Comment on attachment 190482 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190482&action=review > Source/Platform/chromium/public/Platform.h:84 > +class WEBKIT_EXPORT Platform { It doesn't make sense to export Platform. Platform is something we "import" from the embedder... > Source/WebCore/platform/text/chromium/Hyphenation.cpp:36 > - return WebKit::Platform::current()->canHyphenate(localeIdentifier); > + return WebKit::Platform::current()->hyphenator()->canHyphenate(localeIdentifier); If you wait until the embedder supplies a WebHyphenator, then you can make this change much cleaner. I realize that involves landing an extra patch on the Chromium side, but that seems better than going through this intermediate state.
Created attachment 190567 [details] Patch
I guess that should have occurred to me the moment I had to export that Platform. Here's an updated patch (chromium side is also updated)
Created attachment 190579 [details] Patch
Comment on attachment 190579 [details] Patch Clearing flags on attachment: 190579 Committed r144231: <http://trac.webkit.org/changeset/144231>
All reviewed patches have been landed. Closing bug.