Bug 110943 - Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
Summary: Web Inspector: Native Memory Instrumentation: do not visit raw pointers by de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-26 21:56 PST by Ilya Tikhonovsky
Modified: 2013-03-01 21:25 PST (History)
18 users (show)

See Also:


Attachments
Patch (21.38 KB, patch)
2013-02-26 21:59 PST, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (24.28 KB, patch)
2013-03-01 07:00 PST, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2013-02-26 21:56:09 PST
Unfortunately in many cases raw pointers may point to an object that has been deleted.
There is no working solution to solve this problem in general.
It could be solved only on case by case basis.
I'll recheck the biggest memory consumers after that patch.
Comment 1 Ilya Tikhonovsky 2013-02-26 21:59:31 PST
Created attachment 190440 [details]
Patch
Comment 2 Build Bot 2013-02-26 23:52:35 PST
Comment on attachment 190440 [details]
Patch

Attachment 190440 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16764042

New failing tests:
inspector/profiler/memory-instrumentation-cached-images.html
Comment 3 Build Bot 2013-02-27 01:05:26 PST
Comment on attachment 190440 [details]
Patch

Attachment 190440 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16775652

New failing tests:
inspector/profiler/memory-instrumentation-cached-images.html
Comment 4 WebKit Review Bot 2013-02-27 01:54:48 PST
Comment on attachment 190440 [details]
Patch

Attachment 190440 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16789077

New failing tests:
inspector/profiler/memory-instrumentation-canvas.html
inspector/profiler/memory-instrumentation-cached-images.html
Comment 5 WebKit Review Bot 2013-02-27 03:10:14 PST
Comment on attachment 190440 [details]
Patch

Attachment 190440 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16775720

New failing tests:
inspector/profiler/memory-instrumentation-canvas.html
inspector/profiler/memory-instrumentation-cached-images.html
Comment 6 Ilya Tikhonovsky 2013-03-01 07:00:56 PST
Created attachment 190962 [details]
Patch
Comment 7 Yury Semikhatsky 2013-03-01 08:11:14 PST
Comment on attachment 190962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190962&action=review

How much information do we lose by following only smart pointers?

> Source/WTF/wtf/MemoryInstrumentation.h:51
> +    RetainedMember,

RetainingPtrMember
Comment 8 Ilya Tikhonovsky 2013-03-01 21:25:22 PST
Committed r144527: <http://trac.webkit.org/changeset/144527>