Bug 110928 - [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
Summary: [chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-26 17:00 PST by James Robinson
Modified: 2013-04-08 16:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.80 KB, patch)
2013-02-26 17:01 PST, James Robinson 		enne: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-02-26 17:00:51 PST 
[chromium] Remove WebLayerTreeViewClient::(will|did)BeginFrame
Comment 1 James Robinson 2013-02-26 17:01:04 PST 
Created attachment 190396 [details]
Patch
Comment 2 Adrienne Walker 2013-02-26 17:04:09 PST 
Comment on attachment 190396 [details]
Patch

R=me.
Comment 3 James Robinson 2013-02-26 17:11:38 PST 
Committed r144129: <http://trac.webkit.org/changeset/144129>
Comment 4 Vsevolod Vlasov 2013-02-26 23:14:52 PST 
This patch has broken compilation on mac/win

FAILED: clang++ -MMD -MF 
...
../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc -o obj/webkit/compositor_bindings/webkit_compositor_bindings_unittests.web_layer_tree_view_unittest.o
../../webkit/compositor_bindings/web_layer_tree_view_unittest.cc:28:16:error: 'didBeginFrame' marked 'override' but does not override any member functions
  virtual void didBeginFrame() OVERRIDE {
               ^
1 error generated.
ninja: build stopped: subcommand failed.
Comment 5 WebKit Review Bot 2013-02-26 23:17:36 PST 
Re-opened since this is blocked by bug 110947
Comment 7 Vsevolod Vlasov 2013-02-26 23:18:20 PST 
.