Bug 110916 – IndexedDB: Add temporary diagnostic code to IDBRequest.result getter

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: Add temporary diagnostic code to IDBRequest.result getter

[Joshua Bell]

Created attachment 190374 [details]
Patch

[Joshua Bell]

haraken@ - can you take a look?

[Kentaro Hara]

Comment on attachment 190374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190374&action=review

> Source/WebCore/Modules/indexeddb/IDBRequest.idl:36
> +    [Custom] readonly attribute IDBAny result

This should be [V8Custom].

> Source/WebCore/bindings/v8/custom/V8IDBRequestCustom.cpp:55
> +            V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "dummyAttrForDebugging", v8::String::New("foo"));

Let's add a comment about why you added this code.

Maybe you can also add:

  if (wrapper.IsString()) {
    ASSERT(wrapper->Utf8Length() >= 0);
  }

If a wrapper is not sane, it will crash at wrapper->Utf8Length().

[Joshua Bell]

Created attachment 190383 [details]
Patch

[Kentaro Hara]

Comment on attachment 190383 [details]
Patch

Thanks. I hope this change will give us a good hint for further debugging.

[WebKit Review Bot]

Comment on attachment 190383 [details]
Patch

Clearing flags on attachment: 190383

Committed r144125: <http://trac.webkit.org/changeset/144125>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kentaro Hara]

jsbell: Was the crash bug that we've been concerned about fixed by dcarney? If so, we might want to remove the temporary diagnostic hack that was introduced by this change.

[Joshua Bell]

(In reply to comment #8)
> jsbell: Was the crash bug that we've been concerned about fixed by dcarney? If so, we might want to remove the temporary diagnostic hack that was introduced by this change.

I removed this code in http://wkrev.com/144813