Bug 110907 - [Chromium] Enable threaded HTML parser by default in DumpRenderTree
Summary: [Chromium] Enable threaded HTML parser by default in DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 110937 110950
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-02-26 13:29 PST by Adam Barth
Modified: 2013-03-01 13:50 PST (History)
6 users (show)

See Also:


Attachments
Patch (33.93 KB, patch)
2013-02-26 13:31 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (36.52 KB, patch)
2013-02-26 17:09 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (47.35 KB, patch)
2013-02-27 22:29 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-26 13:29:38 PST
[Chromium] Enable threaded HTML parser by default in DumpRenderTree
Comment 1 Adam Barth 2013-02-26 13:31:01 PST
Created attachment 190351 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-26 13:35:12 PST
Comment on attachment 190351 [details]
Patch

LGTM.
Comment 3 WebKit Review Bot 2013-02-26 16:35:13 PST
Comment on attachment 190351 [details]
Patch

Attachment 190351 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16814005

New failing tests:
http/tests/multipart/policy-ignore-crash.php
http/tests/security/XFrameOptions/x-frame-options-allowall.html
Comment 4 Adam Barth 2013-02-26 17:00:19 PST
> http/tests/multipart/policy-ignore-crash.php

I'm going to add this to TestExpectations.  I suspect it's a real bug, but it doesn't need to block turning this feature on.

> http/tests/security/XFrameOptions/x-frame-options-allowall.html

This is a new test that was added since I updated the XFrameOptions baselines.  I'll update it as well.
Comment 5 Adam Barth 2013-02-26 17:09:51 PST
Created attachment 190397 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-26 19:02:02 PST
Comment on attachment 190397 [details]
Patch for landing

Clearing flags on attachment: 190397

Committed r144136: <http://trac.webkit.org/changeset/144136>
Comment 7 WebKit Review Bot 2013-02-26 19:02:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Adam Barth 2013-02-26 22:00:32 PST
Missing baseline added in http://trac.webkit.org/changeset/144143
Comment 9 WebKit Review Bot 2013-02-26 23:55:22 PST
Re-opened since this is blocked by bug 110950
Comment 10 Vsevolod Vlasov 2013-02-27 02:23:11 PST
Tests that started failing after this change and stopped failing when it was rolled out:

compositing/rtl/rtl-iframe-fixed-overflow.html failed in Debug (failed on linux, flaky on win and mac)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Frtl%2Frtl-iframe-fixed-overflow.html

compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html failed in Debug (failed on linux, flaky on win and mac)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=compositing%2Frtl%2Frtl-iframe-absolute-overflow-scrolled.html

accessibility/svg-remote-element.html failed in Win Debug
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Fsvg-remote-element.html

fast/dom/HTMLMeterElement/meter-element-crash.html started flakily failing on Win/Linux Release
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FHTMLMeterElement%2Fmeter-element-crash.html

fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html crashed on assertion in debug ASSERTION FAILED: !pdl->isLoading() on FrameLoader.cpp(2115)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FHTMLAnchorElement%2Fanchor-no-multiple-windows.html

inspector/timeline/timeline-script-tag-1.html failed on Linux Release and Win
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Ftimeline%2Ftimeline-script-tag-1.html

http/tests/multipart/multipart-html.php crashed in debug
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fmultipart-html.php

Tests that started flaking (I am not 100% sure these were caused by this patch):

fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Fimages-enabled-unset-can-block-image-and-can-reload-in-place.html

fast/loader/unload-hyperlink-targeted.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Funload-hyperlink-targeted.html

fast/events/constructors/wheel-event-constructor.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fconstructors%2Fwheel-event-constructor.html

css3/flexbox/multiline-align-self.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fflexbox%2Fmultiline-align-self.html

fast/events/constructors/wheel-event-constructor.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fconstructors%2Fwheel-event-constructor.html

editing/selection/extend-selection-character.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fselection%2Fextend-selection-character.html
Comment 11 Adam Barth 2013-02-27 09:23:56 PST
Thanks for the list!
Comment 12 Eric Seidel (no email) 2013-02-27 12:02:21 PST
Yes!  Thank you very much Vsevolod!
Comment 14 Adam Barth 2013-02-27 22:29:19 PST
Created attachment 190655 [details]
Patch
Comment 15 Adam Barth 2013-02-27 22:42:45 PST
Comment on attachment 190655 [details]
Patch

Clearing flags on attachment: 190655

Committed r144262: <http://trac.webkit.org/changeset/144262>
Comment 16 Adam Barth 2013-02-27 22:42:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 17 Eric Seidel (no email) 2013-03-01 13:47:34 PST
disable-threaded-parser doesnt' seem to be working.
Comment 18 Eric Seidel (no email) 2013-03-01 13:50:01 PST
(In reply to comment #17)
> disable-threaded-parser doesnt' seem to be working.

Nevermind.  My test was overriding:
// Use the threaded parser if available:
if (window.internals && window.internals.settings.setThreadedHTMLParser)
    window.internals.settings.setThreadedHTMLParser(true);