Bug 110907 – [Chromium] Enable threaded HTML parser by default in DumpRenderTree

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

[Chromium] Enable threaded HTML parser by default in DumpRenderTree

[Adam Barth]

Created attachment 190351 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 190351 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 190351 [details]
Patch

Attachment 190351 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16814005

New failing tests:
http/tests/multipart/policy-ignore-crash.php
http/tests/security/XFrameOptions/x-frame-options-allowall.html

[Adam Barth]

> http/tests/multipart/policy-ignore-crash.php

I'm going to add this to TestExpectations.  I suspect it's a real bug, but it doesn't need to block turning this feature on.

> http/tests/security/XFrameOptions/x-frame-options-allowall.html

This is a new test that was added since I updated the XFrameOptions baselines.  I'll update it as well.

[Adam Barth]

Created attachment 190397 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 190397 [details]
Patch for landing

Clearing flags on attachment: 190397

Committed r144136: <http://trac.webkit.org/changeset/144136>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

Missing baseline added in http://trac.webkit.org/changeset/144143

[WebKit Review Bot]

Re-opened since this is blocked by bug 110950

[Vsevolod Vlasov]

Tests that started failing after this change and stopped failing when it was rolled out:

compositing/rtl/rtl-iframe-fixed-overflow.html failed in Debug (failed on linux, flaky on win and mac)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Frtl%2Frtl-iframe-fixed-overflow.html

compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html failed in Debug (failed on linux, flaky on win and mac)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=compositing%2Frtl%2Frtl-iframe-absolute-overflow-scrolled.html

accessibility/svg-remote-element.html failed in Win Debug
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=accessibility%2Fsvg-remote-element.html

fast/dom/HTMLMeterElement/meter-element-crash.html started flakily failing on Win/Linux Release
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FHTMLMeterElement%2Fmeter-element-crash.html

fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html crashed on assertion in debug ASSERTION FAILED: !pdl->isLoading() on FrameLoader.cpp(2115)
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2FHTMLAnchorElement%2Fanchor-no-multiple-windows.html

inspector/timeline/timeline-script-tag-1.html failed on Linux Release and Win
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Ftimeline%2Ftimeline-script-tag-1.html

http/tests/multipart/multipart-html.php crashed in debug
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Fmultipart-html.php

Tests that started flaking (I am not 100% sure these were caused by this patch):

fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Fimages-enabled-unset-can-block-image-and-can-reload-in-place.html

fast/loader/unload-hyperlink-targeted.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Funload-hyperlink-targeted.html

fast/events/constructors/wheel-event-constructor.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fconstructors%2Fwheel-event-constructor.html

css3/flexbox/multiline-align-self.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Fflexbox%2Fmultiline-align-self.html

fast/events/constructors/wheel-event-constructor.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fconstructors%2Fwheel-event-constructor.html

editing/selection/extend-selection-character.html
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fselection%2Fextend-selection-character.html

[Adam Barth]

Thanks for the list!

[Eric Seidel (no email)]

Yes!  Thank you very much Vsevolod!

[Eric Seidel (no email)]

Triaging now:
https://docs.google.com/spreadsheet/ccc?key=0AlC4tS7Ao1fIdE5IbVJESW00V2F5RUIwRDk3WEhMblE#gid=0

[Adam Barth]

Created attachment 190655 [details]
Patch

[Adam Barth]

Comment on attachment 190655 [details]
Patch

Clearing flags on attachment: 190655

Committed r144262: <http://trac.webkit.org/changeset/144262>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

disable-threaded-parser doesnt' seem to be working.

[Eric Seidel (no email)]

(In reply to comment #17)
> disable-threaded-parser doesnt' seem to be working.

Nevermind.  My test was overriding:
// Use the threaded parser if available:
if (window.internals && window.internals.settings.setThreadedHTMLParser)
    window.internals.settings.setThreadedHTMLParser(true);