Bug 110900 - Don't add a body to platform request until necessary
Summary: Don't add a body to platform request until necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 111034
  Show dependency tree / graph
 
Reported: 2013-02-26 12:29 PST by Alexey Proskuryakov
Modified: 2019-10-30 08:31 PDT (History)
12 users (show)

See Also:

Attachments
EWS? (45.25 KB, patch)
2013-02-26 12:33 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
proposed patch (59.04 KB, patch)
2013-02-26 16:41 PST, Alexey Proskuryakov 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
with more Qt build fix (59.01 KB, patch)
2013-02-26 16:54 PST, Alexey Proskuryakov 		buildbot: commit-queue-
Details | Formatted Diff | Diff
and don't break Mac, too (59.00 KB, patch)
2013-02-26 20:11 PST, Alexey Proskuryakov 		beidson: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-02-26 12:29:53 PST 
It is inefficient to send request body with IPC, and it is not even possible to build a body in WebProcess when NetworkProcess is in use, because WebProcess doesn't know what's inside blobs.

This patch will separate body updating from request updating in ResourceRequest. For WebKit1, we will still be creating a body for client callbacks to preserve compatibility. For WebKit2, the body will only be built right before creating an NSURLConnection.
Comment 1 Alexey Proskuryakov 2013-02-26 12:33:51 PST 
Created attachment 190341 [details]
EWS?
Comment 2 Early Warning System Bot 2013-02-26 12:49:56 PST 
Comment on attachment 190341 [details]
EWS?

Attachment 190341 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16775400
Comment 3 EFL EWS Bot 2013-02-26 12:57:46 PST 
Comment on attachment 190341 [details]
EWS?

Attachment 190341 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16770445
Comment 4 Alexey Proskuryakov 2013-02-26 16:41:38 PST 
Created attachment 190390 [details]
proposed patch
Comment 5 Early Warning System Bot 2013-02-26 16:50:16 PST 
Comment on attachment 190390 [details]
proposed patch

Attachment 190390 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16763028
Comment 6 Alexey Proskuryakov 2013-02-26 16:54:26 PST 
Created attachment 190394 [details]
with more Qt build fix
Comment 7 Build Bot 2013-02-26 17:33:43 PST 
Comment on attachment 190394 [details]
with more Qt build fix

Attachment 190394 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16783048
Comment 8 Build Bot 2013-02-26 18:26:25 PST 
Comment on attachment 190394 [details]
with more Qt build fix

Attachment 190394 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16806045
Comment 9 Build Bot 2013-02-26 19:16:11 PST 
Comment on attachment 190394 [details]
with more Qt build fix

Attachment 190394 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16801034
Comment 10 Alexey Proskuryakov 2013-02-26 20:11:20 PST 
Created attachment 190428 [details]
and don't break Mac, too
Comment 11 Alexey Proskuryakov 2013-02-27 11:16:20 PST 
Committed <http://trac.webkit.org/changeset/144216>.