Created attachment 190308 [details] HTML usecase showing the regression Changeset 134631 for bug 101974 broke the ability to use a percentage-based border-radius with a defined border in pixels. Sample CSS showcasing: p{ border-radius:50% 50% 0 0 / 100%; border:1px solid #000; }
Created attachment 190309 [details] Windows Chromium rev168098 showing previous rendering
Created attachment 190310 [details] Windows Chromium rev168117 showing incorrect rendering
Created attachment 190311 [details] Linux Chromium rev168105 showing previous rendering
Created attachment 190313 [details] Linux Chromium rev168117 showing incorrect rendering
Created attachment 190360 [details] Patch
Comment on attachment 190360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190360&action=review > LayoutTests/platform/chromium/TestExpectations:1904 > +# New test in need of pixel baselines > +webkit.org/b/110889 fast/borders/border-radius-percent.html [ ImageOnlyFailure Pass Failure ] What about TestExpectations on other platforms?
Attachment 190360 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/borders/border-radius-percent-expected.txt', u'LayoutTests/fast/borders/border-radius-percent.html', u'LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png', u'LayoutTests/platform/chromium/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBoxModelObject.cpp']" exit_code: 1 LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 190527 [details] Patch for landing
Comment on attachment 190527 [details] Patch for landing Clearing flags on attachment: 190527 Committed r144196: <http://trac.webkit.org/changeset/144196>
All reviewed patches have been landed. Closing bug.