Bug 110862 - Web Inspector: DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
Summary: Web Inspector: DataGrid should reveal and select next/previous DataGridNode u...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-26 02:12 PST by Vivek Galatage
Modified: 2013-02-26 05:45 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.91 KB, patch)
2013-02-26 02:16 PST, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2013-02-26 04:02 PST, Vivek Galatage 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2013-02-26 02:12:36 PST 
DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node. 

Patch follows.
Comment 1 Vivek Galatage 2013-02-26 02:16:16 PST 
Created attachment 190247 [details]
Patch
Comment 2 Eugene Klyuchnikov 2013-02-26 03:34:03 PST 
Comment on attachment 190247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:821
> +                handled = nextSelectedNode ? true : false;

Why deleting last row doesn't count as "handled" case?
Comment 3 Vivek Galatage 2013-02-26 03:35:52 PST 
Comment on attachment 190247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190247&action=review

>> Source/WebCore/inspector/front-end/DataGrid.js:821
>> +                handled = nextSelectedNode ? true : false;
> 
> Why deleting last row doesn't count as "handled" case?

yes its wrong above. It should be handled always as long as there is a valid selectedNode.
Comment 4 Vivek Galatage 2013-02-26 04:02:07 PST 
Created attachment 190256 [details]
Patch
Comment 5 WebKit Review Bot 2013-02-26 05:44:59 PST 
Comment on attachment 190256 [details]
Patch

Clearing flags on attachment: 190256

Committed r144047: <http://trac.webkit.org/changeset/144047>
Comment 6 WebKit Review Bot 2013-02-26 05:45:02 PST 
All reviewed patches have been landed.  Closing bug.