RESOLVED FIXED 110861
new-commit-bot: Some IRC clients doesn't linkify rollout messages 
https://bugs.webkit.org/show_bug.cgi?id=110861
Summary new-commit-bot: Some IRC clients doesn't linkify rollout messages
Vivek Galatage
Reported 2013-02-26 01:30:38 PST
The link to the rollout is suffixed with ':' which makes it invalid URL. e.g. Vsevolod Vlasov (vsevik) rolled out r144016 in https://trac.webkit.org/r144021: Breaks compilation on chromium mac Removing the ':' from the WKR message. Patch follows.
Attachments
Patch (1.73 KB, patch)
2013-02-26 01:33 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2013-02-26 01:49 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2013-02-26 02:02 PST, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-02-26 01:33:05 PST
Created attachment 190239 [details] Patch
Ryosuke Niwa
Comment 2 2013-02-26 01:36:23 PST
Comment on attachment 190239 [details] Patch Sounds like you have a bug in your IRC client. : is a reserved word in URL. It shouldn't be treated like a part of URL.
Ryosuke Niwa
Comment 3 2013-02-26 01:43:03 PST
Oops, apparently colon is allowed to appear in paths of an URL: http://tools.ietf.org/html/rfc3986
Ryosuke Niwa
Comment 4 2013-02-26 01:43:33 PST
Comment on attachment 190239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190239&action=review > Tools/Scripts/webkitpy/tool/commands/newcommitbot.py:150 > - return '%s rolled out %s in %s: %s' % (author, rollout.group('revisions'), > + return '%s rolled out %s in %s %s' % (author, rollout.group('revisions'), Instead of removing the colon, please insert a space before it.
Vivek Galatage
Comment 5 2013-02-26 01:49:14 PST
Created attachment 190242 [details] Patch
Ryosuke Niwa
Comment 6 2013-02-26 01:59:15 PST
Comment on attachment 190242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190242&action=review > Tools/ChangeLog:3 > + [Tools - WKR]Fix the links shown for rollouts by WKR I've updated the bug title to be more describe. Please update the change log accordingly.
Vivek Galatage
Comment 7 2013-02-26 02:02:28 PST
Created attachment 190243 [details] Patch
WebKit Review Bot
Comment 8 2013-02-26 04:54:28 PST
Comment on attachment 190243 [details] Patch Clearing flags on attachment: 190243 Committed r144040: <http://trac.webkit.org/changeset/144040>
WebKit Review Bot
Comment 9 2013-02-26 04:54:31 PST
All reviewed patches have been landed. Closing bug.
Raphael Kubo da Costa (:rakuco)
Comment 10 2013-02-26 07:21:01 PST
This has caused a regression in the Python tests. See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/5360/steps/webkitpy-test/logs/stdio>.
Vivek Galatage
Comment 11 2013-02-26 09:11:37 PST
(In reply to comment #10) > This has caused a regression in the Python tests. See <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/5360/steps/webkitpy-test/logs/stdio>. https://bugs.webkit.org/attachment.cgi?id=190299&action=review should fix this failure. Thank you.
Note You need to log in before you can comment on or make changes to this bug.