Steps: 1) Launch browser and navigate to a webpage 2) Tap on the overflow menu to add to Home Screen. 3) Rotate the device and bring up the Fine Cursor Controller 4) Press and hold to select text 5) Tap on it again to invoke Context Menu Actual: 5) The screen moves up and down or sometimes the Context Menu comes up behind the Keyboard Expected: 5) The Context Menu is displayed and the Virtual Keyboard is dismissed.
Created attachment 190238 [details] patch
Comment on attachment 190238 [details] patch Wrong patch
Created attachment 190240 [details] patch
Attachment 190240 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h']" exit_code: 1 Source/WebKit/blackberry/Api/WebPageClient.h:158: The parameter name "details" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:1024: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:1025: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:1026: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:1027: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:1028: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 190411 [details] patch
Attachment 190411 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPageClient.h', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h']" exit_code: 1 Source/WebKit/blackberry/Api/WebPageClient.h:158: The parameter name "details" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 190418 [details] patch
Comment on attachment 190418 [details] patch based on mike's review
Comment on attachment 190418 [details] patch Clearing flags on attachment: 190418 Committed r144202: <http://trac.webkit.org/changeset/144202>
All reviewed patches have been landed. Closing bug.