Bug 110846 - [JSC] static methods with Callback should not have this pointer
Summary: [JSC] static methods with Callback should not have this pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vineet Chaudhary (vineetc)
URL:
Keywords:
Depends on:
Blocks: 108196
  Show dependency tree / graph
 
Reported: 2013-02-25 22:17 PST by Kaustubh Atrawalkar
Modified: 2013-02-26 13:42 PST (History)
8 users (show)

See Also:

Attachments
patch (12.18 KB, patch)
2013-02-26 10:18 PST, Vineet Chaudhary (vineetc) 		haraken: review-
haraken: commit-queue-
Details | Formatted Diff | Diff
updated_patch (12.63 KB, patch)
2013-02-26 10:38 PST, Vineet Chaudhary (vineetc) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaustubh Atrawalkar 2013-02-25 22:17:06 PST 
Current JSC bindings generator does not support Optional callback as method's argument. Need to add support for the same.
Comment 1 Vineet Chaudhary (vineetc) 2013-02-26 10:18:58 PST 
Created attachment 190322 [details]
patch
Comment 2 Kentaro Hara 2013-02-26 10:23:52 PST 
Comment on attachment 190322 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190322&action=review

The change to CodeGeneratorJS.pm looks good.

> Source/WebCore/bindings/scripts/test/TestObj.idl:150
> +    void    staticMethodWithCallbackAndOptionalArg(in [Callback, Optional] TestCallback callback);
> +    void    staticMethodWithCallbackArg(in [Callback] TestCallback callback);

You need to add 'static' to these methods.
Comment 3 Vineet Chaudhary (vineetc) 2013-02-26 10:38:01 PST 
Created attachment 190324 [details]
updated_patch

Sorry for Copypasta.
Comment 4 Kentaro Hara 2013-02-26 10:48:46 PST 
Comment on attachment 190324 [details]
updated_patch

LGTM
Comment 5 Vineet Chaudhary (vineetc) 2013-02-26 11:28:35 PST 
Comment on attachment 190324 [details]
updated_patch

Thanks!!
Comment 6 WebKit Review Bot 2013-02-26 13:42:00 PST 
Comment on attachment 190324 [details]
updated_patch

Clearing flags on attachment: 190324

Committed r144101: <http://trac.webkit.org/changeset/144101>
Comment 7 WebKit Review Bot 2013-02-26 13:42:04 PST 
All reviewed patches have been landed.  Closing bug.