Bug 110844 – REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

This test doesn't clean up cookies, so they show up in subsequent tests, and in particular break third-party-cookie-relaxing.html, because it depends on whether there are already cookies set for the particular first party.

Bots hide this misbehavior, because they re-run failing tests, this time without set-cookie-on-redirect.html.

Sergio, can you please look into this? I think that the patch will need to be rolled out if this cannot be fixed soon.

[Sergio Villar Senin]

(In reply to comment #0)
> This test doesn't clean up cookies, so they show up in subsequent tests, and in particular break third-party-cookie-relaxing.html, because it depends on whether there are already cookies set for the particular first party.
> 
> Bots hide this misbehavior, because they re-run failing tests, this time without set-cookie-on-redirect.html.
> 
> Sergio, can you please look into this? I think that the patch will need to be rolled out if this cannot be fixed soon.

Sure.

It's true that the test I added does not clean up cookies, but in any case, shouldn't third-party-cookie-relaxing.html call clearAllCookies() at the beginning as the other tests do?

[Alexey Proskuryakov]

Possibly. Cookie testing machinery is extremely fragile, and I'm not sure if that would help.

[Sergio Villar Senin]

Created attachment 190237 [details]
Patch

[WebKit Review Bot]

Comment on attachment 190237 [details]
Patch

Clearing flags on attachment: 190237

Committed r144045: <http://trac.webkit.org/changeset/144045>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Confirmed that the patch helped on Mac. Thank you!

[Dean Jackson]

More reports in https://bugs.webkit.org/show_bug.cgi?id=111650