Bug 110843 - SelectorQuery should not ever use ResolvingStyle mode.
Summary: SelectorQuery should not ever use ResolvingStyle mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 21:34 PST by Dimitri Glazkov (Google)
Modified: 2013-02-26 20:36 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.06 KB, patch)
2013-02-25 21:36 PST, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2013-02-25 21:34:07 PST 
SelectorQuery should not ever use ResolvingStyle mode.
Comment 1 Dimitri Glazkov (Google) 2013-02-25 21:36:44 PST 
Created attachment 190199 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-25 22:57:00 PST 
Comment on attachment 190199 [details]
Patch

So this is just a perf improvement?  Do we have microbenchmarks which would be effected by this?
Comment 3 Dimitri Glazkov (Google) 2013-02-26 07:49:43 PST 
I goess it could be viewed as performance optimization. For instance, when computing webkitMatchesSelector(":first-line"), in ResolvingStyle mode, we would be creating ElementRareData, as opposed to QueryingRules, where we wouldn't be:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/WebCore/dom/Element.cpp&sq=package:chromium&type=cs&rcl=1361871648&l=2071

There's tons of similar things that would do the same types of things in querySelector. Not sure if we have a microbench that would be affected.
Comment 4 WebKit Review Bot 2013-02-26 20:36:21 PST 
Comment on attachment 190199 [details]
Patch

Clearing flags on attachment: 190199

Committed r144140: <http://trac.webkit.org/changeset/144140>
Comment 5 WebKit Review Bot 2013-02-26 20:36:25 PST 
All reviewed patches have been landed.  Closing bug.