Bug 110838 - Add system fallback FontData to FontFallbackList
Summary: Add system fallback FontData to FontFallbackList
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: hyeonji.kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 19:41 PST by hyeonji.kim
Modified: 2013-10-02 12:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2013-02-26 20:42 PST, hyeonji.kim
no flags Details | Formatted Diff | Diff
Patch (2.10 KB, patch)
2013-02-26 21:24 PST, hyeonji.kim
darin: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description hyeonji.kim 2013-02-25 19:41:19 PST
We could reduce layout time by appending system fallback FontData to FontFallbackList.
Comment 1 hyeonji.kim 2013-02-26 20:42:34 PST
Created attachment 190433 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-26 20:51:41 PST
Comment on attachment 190433 [details]
Patch

Attachment 190433 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16767027
Comment 3 Early Warning System Bot 2013-02-26 20:54:20 PST
Comment on attachment 190433 [details]
Patch

Attachment 190433 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16672138
Comment 4 WebKit Review Bot 2013-02-26 21:22:59 PST
Comment on attachment 190433 [details]
Patch

Attachment 190433 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16805023
Comment 5 hyeonji.kim 2013-02-26 21:24:38 PST
Created attachment 190436 [details]
Patch
Comment 6 Build Bot 2013-02-26 22:12:38 PST
Comment on attachment 190436 [details]
Patch

Attachment 190436 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16806085

New failing tests:
css2.1/t0905-c414-flt-fit-01-d-g.html
fast/text/international/danda-space.html
fast/text/international/bidi-mirror-he-ar.html
Comment 7 WebKit Review Bot 2013-02-26 23:17:13 PST
Comment on attachment 190436 [details]
Patch

Attachment 190436 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16667135

New failing tests:
fast/text/emphasis-combined-text.html
css2.1/20110323/word-spacing-characters-002.htm
Comment 8 Build Bot 2013-02-27 00:35:40 PST
Comment on attachment 190436 [details]
Patch

Attachment 190436 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16829028

New failing tests:
css2.1/t0905-c414-flt-fit-01-d-g.html
fast/text/international/danda-space.html
fast/text/international/bidi-mirror-he-ar.html
Comment 9 Darin Adler 2013-03-06 09:15:10 PST
Comment on attachment 190436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190436&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests, covered by existing tests.

How is this covered by existing tests? You are adding this because you say it improves performance. Do you have data on this performance improvement or a test case to demonstrate the speed improvement?
Comment 10 Darin Adler 2013-05-13 18:10:16 PDT
Comment on attachment 190436 [details]
Patch

review- because this breaks regression tests as seen on the mac and mac-wk2 EWS results
Comment 11 hyeonji.kim 2013-05-20 18:27:57 PDT
Webkit dose not cache the fallback fontData. 
So it takes a long time to create same fallback fontData during layout especially at CJK web pages.
Because CJK fontData is usually created using fallback font.
 
This patch is just for caching fallback fontData and it improves performance when fallback fontData is used.
The performance time of FrameView::layout is decreased after applying the patch : 232 milliseconds(before) -> 151 milliseconds (after)
Test site : m.naver.com (Korean web page)