Convert old flexbox uses in html.css to new flexbox
Created attachment 192610 [details] Patch This still fails plenty of tests, but I wanted to backup what I have
Created attachment 193022 [details] Getting closer
Created attachment 193180 [details] Patch Almost there... just one test failing now
Created attachment 193191 [details] Patch Now ready for review\!
Created attachment 193192 [details] Patch
Created attachment 193202 [details] Patch
Created attachment 193203 [details] Patch rebasing
Comment on attachment 193203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193203&action=review Yay! > Source/WebCore/rendering/RenderTextControl.cpp:330 > +RenderTextControlInnerContainer::RenderTextControlInnerContainer(Element* element) > + : RenderFlexibleBox(element) > +{ > +} > + > +RenderTextControlInnerContainer::~RenderTextControlInnerContainer() > +{ > +} I think typically we'd just put these directly in the header. > Source/WebCore/rendering/RenderTextControl.h:103 > +// baseline definition, and then inputs of different types wouldn't like up s/like/line
Created attachment 193383 [details] Patch
Comment on attachment 193383 [details] Patch Rejecting attachment 193383 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 193383, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: nerElements.cpp M Source/WebCore/html/shadow/TextControlInnerElements.h M Source/WebCore/html/shadow/TextFieldDecorationElement.cpp M Source/WebCore/rendering/RenderTextControl.h M Source/WebCore/rendering/RenderTextControlSingleLine.cpp Merge conflict during commit: Conflict at '/trunk/LayoutTests/ChangeLog' at /usr/lib/git-core/git-svn line 570 Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue ects from gyp files... Total errors found: 0 in 1 files Full output: http://webkit-commit-queue.appspot.com/results/17231039
Comment on attachment 193383 [details] Patch Clearing flags on attachment: 193383 Committed r145977: <http://trac.webkit.org/changeset/145977>
Tests started to fail on Mac <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r145977%20(6962)/results.html>. Will fix.
Also, there was one "-webkit-box-flex: 0;" missed here: input::-webkit-clear-button { -webkit-appearance: searchfield-cancel-button; display: inline-block; -webkit-box-flex: 0; -webkit-user-modify: read-only !important; margin-left: 2px; }
Simon, sorry about missing that one test. Thanks for fixing. David, thanks for pointing that out. Looks like it was added while I was working on this bug, so I missed it. I'll fix.
Created attachment 193614 [details] Patch
Comment on attachment 193614 [details] Patch Clearing flags on attachment: 193614 Committed r146103: <http://trac.webkit.org/changeset/146103>