RESOLVED FIXED 110830
Add month popup for new calendar picker 
https://bugs.webkit.org/show_bug.cgi?id=110830
Summary Add month popup for new calendar picker
Keishi Hattori
Reported 2013-02-25 18:06:43 PST
Add month popup for new calendar picker (Bug 109439)
Attachments
Patch (24.23 KB, patch)
2013-02-25 21:21 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (24.19 KB, patch)
2013-02-27 03:42 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2013-02-25 21:21:05 PST
Created attachment 190197 [details] Patch
Kent Tamura
Comment 2 2013-02-26 04:50:53 PST
Comment on attachment 190197 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190197&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:2153 > + this.dispatchEvent("didSelectMonth", this, new Month(year, month)); "didSelectMonth" -> YearListView.EventTypeYearListViewDidSelectMonth ? > Source/WebCore/Resources/pagepopups/calendarPicker.js:2179 > + var row = parseInt(rowsWithIrregularHeight[i], 10); Is this parseInt necessary? > Source/WebCore/Resources/pagepopups/calendarPicker.js:2407 > + eventHandled = this._moveHighlightTo(Month.createFromToday()); > + eventHandled = true; Setting eventHandled twice looks bad.
Keishi Hattori
Comment 3 2013-02-27 03:42:13 PST
Created attachment 190486 [details] Patch
Kent Tamura
Comment 4 2013-02-27 06:12:59 PST
Comment on attachment 190486 [details] Patch looks ok
WebKit Review Bot
Comment 5 2013-02-27 18:26:11 PST
Comment on attachment 190486 [details] Patch Clearing flags on attachment: 190486 Committed r144254: <http://trac.webkit.org/changeset/144254>
WebKit Review Bot
Comment 6 2013-02-27 18:26:14 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.