Bug 110827 - Add cookies to FastMalloc spans
Summary: Add cookies to FastMalloc spans
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 17:54 PST by Oliver Hunt
Modified: 2013-02-26 12:41 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.85 KB, patch)
2013-02-25 17:57 PST, Oliver Hunt 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-02-25 17:54:27 PST 
As it says in the title.
Comment 1 Oliver Hunt 2013-02-25 17:57:46 PST 
Created attachment 190168 [details]
Patch
Comment 2 Michael Saboff 2013-02-25 18:10:23 PST 
Comment on attachment 190168 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190168&action=review

> Source/WTF/ChangeLog:12
> +        (WTF):

Remove this line.
Comment 3 Oliver Hunt 2013-02-25 18:15:15 PST 
Committed r143996: <http://trac.webkit.org/changeset/143996>
Comment 5 Ryosuke Niwa 2013-02-25 18:55:17 PST 
This patch broke builds other than Mac and Chromium ports.
Comment 6 Ryosuke Niwa 2013-02-25 19:17:19 PST 
(In reply to comment #5)
> This patch broke builds other than Mac and Chromium ports.

Tried to fix this in http://trac.webkit.org/changeset/144001. Does the fix look right to you?
Comment 7 Oliver Hunt 2013-02-25 19:29:48 PST 
(In reply to comment #6)
> (In reply to comment #5)
> > This patch broke builds other than Mac and Chromium ports.
> 
> Tried to fix this in http://trac.webkit.org/changeset/144001. Does the fix look right to you?

Gah, sorry!

Yes it looks correct.  My bad.
Comment 8 Adam Barth 2013-02-26 12:09:20 PST 
This patch might have caused a performance regression on the chromium-mac port.  There are some other performance regression rollouts in progress.  If they don't heal the bot, I'm going to try rolling this one out as well.
Comment 9 Oliver Hunt 2013-02-26 12:14:17 PST 
(In reply to comment #8)
> This patch might have caused a performance regression on the chromium-mac port.  There are some other performance regression rollouts in progress.  If they don't heal the bot, I'm going to try rolling this one out as well.

Really?  I'll rerun perf tests locally - what is the hardware that chr-mac is running on?
Comment 10 Adam Barth 2013-02-26 12:19:50 PST 
(In reply to comment #9)
> (In reply to comment #8)
> > This patch might have caused a performance regression on the chromium-mac port.  There are some other performance regression rollouts in progress.  If they don't heal the bot, I'm going to try rolling this one out as well.
> 
> Really?  I'll rerun perf tests locally - what is the hardware that chr-mac is running on?

I don't know for certain, but I would guess a Mac Mini.
Comment 11 Adam Barth 2013-02-26 12:41:32 PST 
The perf graph is actually looking pretty good right now.  I'm going to let it cycle a few more times, but it looks like you're off the hook.  :)