Bug 110819 – Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Tony Gentilcore]

1. Record a timeline that includes a page load. Notice the presence of DOMContentLoaded and Load event markers.
2. Right click and "Save Timeline data..."
3. Close inspector, open a new inspector, right click on timeline and "Load Timeline data..."
4. Notice DOMContentLoaded and Load event markers are gone.

I expect DOMContentLoaded and Load event markers should survive saving and loading the timeline.

[Eugene Klyuchnikov]

Created attachment 190315 [details]
Patch

[Build Bot]

Comment on attachment 190315 [details]
Patch

Attachment 190315 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16781302

New failing tests:
inspector/timeline/timeline-load-event.html
inspector/timeline/timeline-dom-content-loaded-event.html

[WebKit Review Bot]

Comment on attachment 190315 [details]
Patch

Attachment 190315 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16782211

New failing tests:
inspector/timeline/timeline-load-event.html
inspector/timeline/timeline-dom-content-loaded-event.html

[Build Bot]

Comment on attachment 190315 [details]
Patch

Attachment 190315 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16769558

New failing tests:
inspector/timeline/timeline-dom-content-loaded-event.html
inspector/timeline/timeline-load-event.html

[Eugene Klyuchnikov]

Created attachment 190438 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 190438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190438&action=review

> Source/WebCore/ChangeLog:3
> +        Save/load timeline should preserve DOMContentLoaded and Load event markers

Please provide Web Inspector prefix.

> Source/WebCore/ChangeLog:8
> +        Store "isMainFrame" flag in MarkLoad and MarkDOMConatent records data.

It is not clear from the description what was the root of problem and how it was fixed.

[Eugene Klyuchnikov]

Analysis:
 TimelinePresentationModel creates event dividers for MarkLoad and MarkDOMContent only if they are fired for main frame.
 It uses resource resourceTreeModel to check if given frame id is main frame id.
 This is not good because at time check is performed, main frame could have changed (for example when we load saved timeline data).
 With this patch check is performed at time record is created and result is saved as a part of record.

[Eugene Klyuchnikov]

Comment on attachment 190438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190438&action=review

>> Source/WebCore/ChangeLog:3
>> +        Save/load timeline should preserve DOMContentLoaded and Load event markers
> 
> Please provide Web Inspector prefix.

Fixed.

>> Source/WebCore/ChangeLog:8
>> +        Store "isMainFrame" flag in MarkLoad and MarkDOMConatent records data.
> 
> It is not clear from the description what was the root of problem and how it was fixed.

Fixed.

[Eugene Klyuchnikov]

Created attachment 190447 [details]
Patch

[Pavel Feldman]

Comment on attachment 190447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190447&action=review

> Source/WebCore/inspector/TimelineRecordFactory.cpp:190
> +    data->setBoolean("mainFrame", mainFrame);

isMainFrame

[Eugene Klyuchnikov]

Created attachment 190929 [details]
Patch

[Eugene Klyuchnikov]

Comment on attachment 190447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190447&action=review

>> Source/WebCore/inspector/TimelineRecordFactory.cpp:190
>> +    data->setBoolean("mainFrame", mainFrame);
> 
> isMainFrame

Done

[Eugene Klyuchnikov]

Committed r144439: <http://trac.webkit.org/changeset/144439>