Bug 110812 - Implement channel up-mixing and down-mixing rules
Summary: Implement channel up-mixing and down-mixing rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 15:16 PST by Chris Rogers
Modified: 2013-02-27 13:49 PST (History)
8 users (show)

See Also:

Attachments
Patch (40.79 KB, patch)
2013-02-25 15:25 PST, Chris Rogers 		kbr: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2013-02-25 15:16:24 PST 
Implement channel up-mixing and down-mixing rules
Comment 1 Chris Rogers 2013-02-25 15:25:31 PST 
Created attachment 190140 [details]
Patch
Comment 2 Kenneth Russell 2013-02-26 12:48:40 PST 
Comment on attachment 190140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190140&action=review

Looks good. Thanks for the explanation offline about the algorithm and the layout test. One comment.

> Source/WebCore/platform/audio/AudioBus.cpp:385
> +        vadd(sourceC, 1, destination, 1, destination, 1, length());

This is basically exactly the same code as in speakersCopyFrom. Could you refactor it into a separate method to share the code?
Comment 3 Chris Rogers 2013-02-27 13:49:10 PST 
Committed r144235: <http://trac.webkit.org/changeset/144235>