Bug 110807 - Page::m_isInWindow is uninitialized
Summary: Page::m_isInWindow is uninitialized
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 14:41 PST by Tim Horton
Modified: 2013-02-25 15:37 PST (History)
2 users (show)

See Also:


Attachments
patch (1.09 KB, patch)
2013-02-25 14:43 PST, Tim Horton
no flags Details | Formatted Diff | Diff
sad patch (1.09 KB, patch)
2013-02-25 15:25 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-02-25 14:41:40 PST
Should be false by default, we'll get put into a window later.
Comment 1 Tim Horton 2013-02-25 14:43:09 PST
Created attachment 190132 [details]
patch
Comment 2 Tim Horton 2013-02-25 14:45:27 PST
Comment on attachment 190132 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190132&action=review

> Source/WebCore/page/Page.cpp:164
>      , m_isOnscreen(true)

Hmm, that's odd.
Comment 3 Simon Fraser (smfr) 2013-02-25 14:46:31 PST
Comment on attachment 190132 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190132&action=review

>> Source/WebCore/page/Page.cpp:164
>>      , m_isOnscreen(true)
> 
> Hmm, that's odd.

Should we change this?
Comment 4 Tim Horton 2013-02-25 15:02:59 PST
I think we should. A Page shouldn't be onscreen (or in-window) by default - until it's added to a platform view/window/etc. Any ports that see fallout from such a change should probably make sure that they're calling setIsInWindow/willMoveOffscreen/didMoveOnscreen at the appropriate times...
Comment 5 Tim Horton 2013-02-25 15:25:23 PST
Ugh, none of the other ports bother to update onscreen or in-window state. Instead of implementing this for all the ports, I'm going to (unfortunately) match m_isOnscreen and default to true. WK2 sets it to the correct value very quickly anyway, so this isn't a big deal.
Comment 6 Tim Horton 2013-02-25 15:25:46 PST
Created attachment 190141 [details]
sad patch
Comment 7 Simon Fraser (smfr) 2013-02-25 15:28:09 PST
Comment on attachment 190141 [details]
sad patch

r=me but please justify your odd choice more in the Changelog.
Comment 8 Tim Horton 2013-02-25 15:37:23 PST
http://trac.webkit.org/changeset/143979