This would be the final step of generating wrapper functions. The patch generates the following wrapper function for named constructor callbacks. Handle<Value> namedConstructorCallback() { return namedConstructor(); }
Created attachment 190122 [details] Patch
Comment on attachment 190122 [details] Patch Clearing flags on attachment: 190122 Committed r144157: <http://trac.webkit.org/changeset/144157>
All reviewed patches have been landed. Closing bug.
Reverted r144157 for reason: It broke chromium windows build Committed r144322: <http://trac.webkit.org/changeset/144322>
Created attachment 190765 [details] Patch
I fixed the windows build error: http://master.chrome.corp.google.com:8010/builders/win/builds/933/steps/compile/logs/stdio It was a problem of namespace conflict. To avoid the conflict: - namedConstructorCallback() should be a static method of class V8XXX. - namedConstructor() should be in the namespace XXXV8Internal.
abarth: would you review?
Comment on attachment 190765 [details] Patch Thanks!
Comment on attachment 190765 [details] Patch Rejecting attachment 190765 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 190765, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13737 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 54>At revision 13737. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://webkit-commit-queue.appspot.com/results/16864021
V8 is gone.