Bug 110783 - [texmap] Rename TextureMapperGL::ClipStack::init to reset
Summary: [texmap] Rename TextureMapperGL::ClipStack::init to reset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bruno Abinader (history only)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 12:37 PST by Bruno Abinader (history only)
Modified: 2013-02-25 20:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.48 KB, patch)
2013-02-25 12:41 PST, Bruno Abinader (history only) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Abinader (history only) 2013-02-25 12:37:01 PST 
When debugging over TextureMapper::ClipStack, I've noticed that the ClipStack::init() function is used not only when begin painting, but also when clearing. I'm used to see init() functions being called inside ctor's to initialize member variables that were unable to be assigned on an initialization list, which is not the case, and also because reset() better reflects the behavior (clears the clip stack and assigns a value to the initial clip state).
Comment 1 Bruno Abinader (history only) 2013-02-25 12:41:10 PST 
Created attachment 190106 [details]
Patch

Proposed patch
Comment 2 WebKit Review Bot 2013-02-25 20:06:31 PST 
Comment on attachment 190106 [details]
Patch

Clearing flags on attachment: 190106

Committed r144003: <http://trac.webkit.org/changeset/144003>
Comment 3 WebKit Review Bot 2013-02-25 20:06:35 PST 
All reviewed patches have been landed.  Closing bug.