Bug 110781 - [V8] Generate a wrapper function for ReplaceableAttrSetter()
Summary: [V8] Generate a wrapper function for ReplaceableAttrSetter()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 110667
  Show dependency treegraph
Reported: 2013-02-25 12:21 PST by Kentaro Hara
Modified: 2013-02-27 08:43 PST (History)
2 users (show)

See Also:

Patch (9.67 KB, patch)
2013-02-25 12:24 PST, Kentaro Hara
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-25 12:21:42 PST
This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for xxxReplaceableAttrSetter(), like this:

// For non-custom replaceable setters (Note: One implementation is enough for all replaceable setters in one interface.)
void V8XXX:::ReplaceableAttrSetterCallback(...) {

// For custom replaceable setters. (Note: This is treated as a normal custom setter.)
void xxxAttrSetterCallback(...) {
  return xxxAttrSetterCustom(...);
Comment 1 Kentaro Hara 2013-02-25 12:24:41 PST
Created attachment 190103 [details]
Comment 2 WebKit Review Bot 2013-02-27 00:53:45 PST
Comment on attachment 190103 [details]

Rejecting attachment 190103 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 190103, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
patching file Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Hunk #1 succeeded at 1548 (offset 252 lines).
Hunk #2 succeeded at 2896 (offset 606 lines).
Hunk #3 succeeded at 2933 with fuzz 1 (offset 606 lines).
patching file Source/WebCore/bindings/scripts/test/V8/V8TestTypedefs.cpp
Hunk #1 succeeded at 252 (offset 30 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/16771578
Comment 3 Kentaro Hara 2013-02-27 08:43:56 PST
Committed r144194: <http://trac.webkit.org/changeset/144194>