Bug 110773 – WebSpeech: change voiceURI to voice

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

https://www.w3.org/Bugs/Public/show_bug.cgi?id=20529

http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi-errata.html

[chris fleizach]

E07 2013-02-25 (Important):
Section 5.2 IDL: SpeechSynthesisUtterance "attribute DOMString voiceURI" should be "attribute SpeechSynthesisVoice voice".
Section 5.2.3 SpeechSynthesisUtterance Attributes: "voiceURI attribute" should be "voice attribute", with the following definition:
The voice attribute specifies speech synthesis voice that the web application wishes to use. If, at the time of the play method call, this attribute has been set to one of the SpeechSynthesisVoice objects returned by getVoices, then the user agent MUST use that voice. If this attribute is unset or null at the time of the play method call, then the user agent MUST use a user agent default voice. The user agent default voice SHOULD support the current language (see "lang" attribute) and can be a local or remote speech service and can incorporate end user choices via interfaces provided by the user agent such as browser configuration parameters.
Section 5.2.6 SpeechSynthesisVoice: voiceURI attribute: "as described in the SpeechSynthesisUtterance voiceURI attribute" should be "either through use of a URN with meaning to the user agent or by specifying a URL that the user agent recognizes as a local service."

[chris fleizach]

Created attachment 190816 [details]
patch

[chris fleizach]

Adding Beth for review

[Tim Horton]

Comment on attachment 190816 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190816&action=review

I don't know enough about this code to know if the object lifetimes are right...

> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:-34
> -    attribute DOMString voiceURI;

Is it OK to just remove the old property?

> Source/WebCore/platform/PlatformSpeechSynthesisUtterance.cpp:35
> +    , m_voice(0)

null is the default value for RefPtr.

> Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:86
> +    WebCore::PlatformSpeechSynthesisVoice *utteranceVoice = utterance->voice();

This * is on the wrong side; PlatformSpeechSynthesisVoice is a C++ class.

[chris fleizach]

(In reply to comment #4)
> (From update of attachment 190816 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190816&action=review
> 
> I don't know enough about this code to know if the object lifetimes are right...
> 
> > Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:-34
> > -    attribute DOMString voiceURI;
> 
> Is it OK to just remove the old property?

This feature has not yet been enabled on any platform, so we should be ok

> 
> > Source/WebCore/platform/PlatformSpeechSynthesisUtterance.cpp:35
> > +    , m_voice(0)
> 
> null is the default value for RefPtr.
> 
> > Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:86
> > +    WebCore::PlatformSpeechSynthesisVoice *utteranceVoice = utterance->voice();
> 
> This * is on the wrong side; PlatformSpeechSynthesisVoice is a C++ class.

hmm, bug in the style checker!

[Tim Horton]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 190816 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=190816&action=review
> > 
> > I don't know enough about this code to know if the object lifetimes are right...
> > 
> > > Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:-34
> > > -    attribute DOMString voiceURI;
> > 
> > Is it OK to just remove the old property?
> 
> This feature has not yet been enabled on any platform, so we should be ok

Perfect!

> > 
> > > Source/WebCore/platform/PlatformSpeechSynthesisUtterance.cpp:35
> > > +    , m_voice(0)
> > 
> > null is the default value for RefPtr.
> > 
> > > Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:86
> > > +    WebCore::PlatformSpeechSynthesisVoice *utteranceVoice = utterance->voice();
> > 
> > This * is on the wrong side; PlatformSpeechSynthesisVoice is a C++ class.
> 
> hmm, bug in the style checker!

I don't think the style checker can tell if it's an C++ or ObjC class so it doesn't try to correct that particular style nit :D

[chris fleizach]

http://trac.webkit.org/changeset/144679