This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for xxxMethod(), like this: // For non-custom methods void xxxMethodCallback(...) { xxxMethod(...); } // For custom methods void xxxMethodCallback(...) { return xxxMethodCustom(...); }
Created attachment 190097 [details] Patch
Comment on attachment 190097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190097&action=review > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1473 > -sub GenerateOverloadedFunctionCallback > +sub GenerateOverloadedFunction The diff is confusing, but basically I just factored ${name}MethodCallback() out of GenerateOverloadedFunctionCallback(). > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:1533 > + push(@implContentDecls, " return ${v8InterfaceName}::${name}MethodCustom(args);\n"); > + } else { > + push(@implContentDecls, " return ${interfaceName}V8Internal::${name}Method(args);\n"); > + } And this is the essential part of the patch. Other diffs are just for making this part workable.
Committed r143967: <http://trac.webkit.org/changeset/143967>