Bug 110765 – [V8] Generate a wrapper method for constructor callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for constructor(), like this:

// For non-custom constructors
void constructorCallback(...) {
  return constructor(...);
}

// For custom constructors
void constructorCallback(...) {
  return constructorCustom(...);
}

[Kentaro Hara]

Created attachment 190088 [details]
Patch

[Kentaro Hara]

Comment on attachment 190088 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190088&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2014
> +    if (HasCustomConstructor($interface)) {
> +        push(@implContent, "    return V8${interfaceName}::constructorCustom(args);\n");
> +    } else {
> +        push(@implContent, "    return ${interfaceName}V8Internal::constructor(args);\n");
> +    }

This is the essential part of this patch. Other diffs are just for making this part work.

[Adam Barth]

Comment on attachment 190088 [details]
Patch

ok

[Kentaro Hara]

Committed r143965: <http://trac.webkit.org/changeset/143965>