Bug 110752 - OpenCL implementation of FEImage SVG Filter.
Summary: OpenCL implementation of FEImage SVG Filter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 70099
  Show dependency tree / graph
 
Reported: 2013-02-25 05:46 PST by Tamas Czene
Modified: 2013-02-28 03:52 PST (History)
8 users (show)

See Also:

Attachments
proposed patch (4.33 KB, patch)
2013-02-25 05:47 PST, Tamas Czene 		no flags Details | Formatted Diff | Diff
proposed patch (4.36 KB, patch)
2013-02-25 05:48 PST, Tamas Czene 		no flags Details | Formatted Diff | Diff
proposed patch (4.35 KB, patch)
2013-02-27 02:00 PST, Tamas Czene 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2013-02-25 05:46:23 PST 
This implementation runs the software method and then it uploads the results to the OpenCL device.
Comment 1 Tamas Czene 2013-02-25 05:47:13 PST 
Created attachment 190042 [details]
proposed patch
Comment 2 Tamas Czene 2013-02-25 05:48:58 PST 
Created attachment 190044 [details]
proposed patch
Comment 3 Zoltan Herczeg 2013-02-27 01:41:12 PST 
Comment on attachment 190044 [details]
proposed patch

Good patch, but the patch does not apply. Could you reupload the patch for chechking it again?
Comment 4 Tamas Czene 2013-02-27 02:00:19 PST 
Created attachment 190472 [details]
proposed patch
Comment 5 Stephen Chenney 2013-02-27 05:34:51 PST 
Comment on attachment 190472 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review

> Source/WebCore/svg/graphics/filters/SVGFEImage.h:43
> +    virtual bool platformApplyOpenCL();

This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL.
Comment 6 Zoltan Herczeg 2013-02-28 03:42:45 PST 
(In reply to comment #5)
> (From update of attachment 190472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190472&action=review
> 
> > Source/WebCore/svg/graphics/filters/SVGFEImage.h:43
> > +    virtual bool platformApplyOpenCL();
> 
> This has not been enforced on your patches to date, but WebKit standards say that all implementations of virtual methods must be explicitly marked OVERRIDE. Leave it for now but please follow up with a patch to fix all the overrides of platformApplyOpenCL.

Good point.
Comment 7 Zoltan Herczeg 2013-02-28 03:43:40 PST 
Comment on attachment 190472 [details]
proposed patch

r=me, but please make a follow-up patch for fixing all virtual methods.
Comment 8 WebKit Review Bot 2013-02-28 03:52:27 PST 
Comment on attachment 190472 [details]
proposed patch

Clearing flags on attachment: 190472

Committed r144289: <http://trac.webkit.org/changeset/144289>
Comment 9 WebKit Review Bot 2013-02-28 03:52:31 PST 
All reviewed patches have been landed.  Closing bug.