Bug 110738 - [BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
Summary: [BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-25 01:53 PST by Carlos Garcia Campos
Modified: 2013-02-25 05:15 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2013-02-25 01:56 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch (9.89 KB, patch)
2013-02-25 02:09 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-02-25 01:53:42 PST 
There are a lot of warnings like this one when building JavaScriptCore in ARM.

Source/JavaScriptCore/runtime/ArrayStorage.h:52:103: warning: cast from 'JSC::Butterfly*' to 'JSC::ArrayStorage*' increases required alignment of target type [-Wcast-align]
Comment 1 Carlos Garcia Campos 2013-02-25 01:56:00 PST 
Created attachment 190019 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-02-25 02:09:17 PST 
Created attachment 190020 [details]
Updated patch

I had missed a few more cases in previous patch.
Comment 3 Rob Buis 2013-02-25 04:26:27 PST 
Comment on attachment 190020 [details]
Updated patch

Looks good.
Comment 4 WebKit Review Bot 2013-02-25 05:15:33 PST 
Comment on attachment 190020 [details]
Updated patch

Clearing flags on attachment: 190020

Committed r143909: <http://trac.webkit.org/changeset/143909>
Comment 5 WebKit Review Bot 2013-02-25 05:15:36 PST 
All reviewed patches have been landed.  Closing bug.