Bug 110737 – XSSAuditor tests shouldn't depend on IFrames's load order.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Mike West]

Tests like http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-unterminated.html currently pass only because the error messages aren't detailed enough to distinguish between the order in which the IFrames load. Before increasing the error message detail, we'll need to break these out into tests that always load in the same order.

Two options:

1. Serialize loading via something like `onload="loadNextFrame()"`.
2. Break multiple-IFrame tests into multiple single-IFrame tests.

The latter seems faster.

[Mike West]

Created attachment 190021 [details]
Patch

[Mike West]

Would you mind taking a quick look, Jochen?

Comment on attachment 190021 [details]
Patch

ok

did you check whether any test expectations need to be updated?

[Mike West]

(In reply to comment #3)
> (From update of attachment 190021 [details])
> ok
> 
> did you check whether any test expectations need to be updated?

I nuked the expected files and regenerated with --reset-result. These results should be accurate, but I'll wait for the bots to go through before landing. :)

[WebKit Review Bot]

Comment on attachment 190021 [details]
Patch

Attachment 190021 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16740950

New failing tests:
fast/js/dfg-inline-resolve.html

[Mike West]

Created attachment 190028 [details]
Patch

[Mike West]

Comment on attachment 190028 [details]
Patch

Clearing r?, carrying over Jochen's r+. Let's see what the bots think.

[Build Bot]

Comment on attachment 190028 [details]
Patch

Attachment 190028 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16760037

New failing tests:
http/tests/security/xssAuditor/property-escape-quote-01.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/property-escape-quote-02.html
http/tests/security/xssAuditor/property-escape-quote-03.html
http/tests/security/xssAuditor/open-iframe-src-02.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html
http/tests/security/xssAuditor/open-iframe-src-01.html

[Mike West]

(In reply to comment #8)
> (From update of attachment 190028 [details])
> Attachment 190028 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://queues.webkit.org/results/16760037
> 
> New failing tests:
> http/tests/security/xssAuditor/property-escape-quote-01.html
> http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
> http/tests/security/xssAuditor/property-escape-quote-02.html
> http/tests/security/xssAuditor/property-escape-quote-03.html
> http/tests/security/xssAuditor/open-iframe-src-02.html
> http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html
> http/tests/security/xssAuditor/open-iframe-src-01.html

Ah. Right. I should actually generate expectations for new tests. *cough* :)

[Mike West]

Created attachment 190045 [details]
Patch

[Mike West]

Comment on attachment 190045 [details]
Patch

CQing.

[WebKit Review Bot]

Comment on attachment 190045 [details]
Patch

Clearing flags on attachment: 190045

Committed r143920: <http://trac.webkit.org/changeset/143920>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.