These are new suggestion box classes to support the datalist UI for textfields.
Created attachment 190018 [details] Patch
Attachment 190018 [details] did not pass style-queue: Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:1272: Should have a space between // and comment [whitespace/comments] [4] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:125: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:126: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:127: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:129: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:134: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:136: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:140: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:142: Omit int when using unsigned [runtime/unsigned] [1] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:143: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:144: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:145: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:146: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:148: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indenFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/themeBlackBerry.css', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp', u'Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/PlatformBlackBerry.cmake', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxElement.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxElement.h', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp', u'Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.h', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp', u'Source/WebKit/blackberry/WebKitSupport/InputHandler.h', u'Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp']" exit_code: 1 t] [3] Source/WebKit/blackberry/WebCoreSupport/SuggestionBoxHandler.cpp:149: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 26 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190018 [details] Patch We should fix coding style before upstreaming this.
Created attachment 190070 [details] Patch Here's the updated patch
Created attachment 190272 [details] Patch The author of the code was missing in the changelog
Comment on attachment 190272 [details] Patch Looks good to me!
Comment on attachment 190272 [details] Patch LGTM.
Comment on attachment 190272 [details] Patch Clearing flags on attachment: 190272 Committed r144063: <http://trac.webkit.org/changeset/144063>
All reviewed patches have been landed. Closing bug.