Bug 110729 - REGRESSION(r143804): Causes multiple html5lib/ tests timeout (Requested by vsevik on #webkit).
Summary: REGRESSION(r143804): Causes multiple html5lib/ tests timeout (Requested by vs...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 110643
  Show dependency treegraph
 
Reported: 2013-02-25 00:15 PST by WebKit Review Bot
Modified: 2013-02-25 00:31 PST (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r143804 (21.72 KB, patch)
2013-02-25 00:16 PST, WebKit Review Bot
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2013-02-25 00:15:29 PST
http://trac.webkit.org/changeset/143804 broke the build:
Causes multiple html5lib/ tests timeout (Requested by vsevik on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2013-02-25 00:16:01 PST
Created attachment 190007 [details]
ROLLOUT of r143804

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Eric Seidel (no email) 2013-02-25 00:29:17 PST
Comment on attachment 190007 [details]
ROLLOUT of r143804

Great, we shoudl just mark them as slow.  This is expected.  Can you give me an example?
Comment 3 Eric Seidel (no email) 2013-02-25 00:29:37 PST
I'm making all the tests take twice (or more) as long with this change.  This is intentional. :)
Comment 4 Eric Seidel (no email) 2013-02-25 00:31:13 PST
I do not believe rollout is the right resolution for this change, but I'm off to bed.  If you disagree, you should feel welcome to re-open this bug and complete the rollout.  But it's much better to mark these tests as slow if necessary.  We can split them up into smaller tests later if needed.  There is already a bug on file to do that for the main test.