Bug 110716 - [Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
Summary: [Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-24 12:53 PST by Eric Carlson
Modified: 2013-02-24 20:00 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (7.94 KB, patch)
2013-02-24 13:11 PST, Eric Carlson 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Updated patch. (8.35 KB, patch)
2013-02-24 14:41 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-02-24 12:53:59 PST 
Minor cleanup of the MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF classes
Comment 1 Radar WebKit Bug Importer 2013-02-24 12:54:31 PST 
<rdar://problem/13281692>
Comment 2 Eric Carlson 2013-02-24 13:11:28 PST 
Created attachment 189987 [details]
Proposed patch
Comment 3 Build Bot 2013-02-24 13:37:41 PST 
Comment on attachment 189987 [details]
Proposed patch

Attachment 189987 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16730681
Comment 4 Build Bot 2013-02-24 14:01:15 PST 
Comment on attachment 189987 [details]
Proposed patch

Attachment 189987 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16735666
Comment 5 Eric Carlson 2013-02-24 14:41:55 PST 
Created attachment 189988 [details]
Updated patch.
Comment 6 Alexey Proskuryakov 2013-02-24 16:13:58 PST 
Comment on attachment 189988 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=189988&action=review

> Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:40
> +    virtual ~AVFInbandTrackParent() { }

Since there is already a matching .cpp file, it's better to to have the implementation there. Inlining destructors and constructors of polymorphic classes significantly and unnecessarily increases code bloat.
Comment 7 Eric Carlson 2013-02-24 20:00:23 PST 
Committed http://trac.webkit.org/changeset/143884.