Bug 110714 – Clarify meaning of default default encoding localizable string

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alexey Proskuryakov]

/* The default, default character encoding */
 "ISO-8859-1" = "ISO-8859-1";

This string only has effect on Windows, but there is nothing telling localizers so, and it's a huge source of confusion.

[Alexey Proskuryakov]

Created attachment 189981 [details]
proposed patch

Does this comment aid localization? Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like

/* (Used only on Windows) The IANA name of the default default character encoding */

"DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1";

[Alexey Proskuryakov]

(In reply to comment #2)
> Does this comment aid localization? 

Yes, that's its purpose, and it's certainly visible in relevant tools.

>Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like
> 
> /* (Used only on Windows) The IANA name of the default default character encoding */
> 
> "DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1";

This is only needed when there are multiple localizable strings that are the same in English, but not necessarily the same in other languages. But we only use the "ISO-8859-1" key once.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/143881>.

(In reply to comment #3)
> (In reply to comment #2)
> > Does this comment aid localization? 
> 
> Yes, that's its purpose, and it's certainly visible in relevant tools.

I was referring to the particular comment in your patch.

> 
> >Perhaps this is one of those cases where they key shouldn’t be the same as the English localization? Something like
> > 
> > /* (Used only on Windows) The IANA name of the default default character encoding */
> > 
> > "DEFAULT_DEFAULT_CHARACTER_ENCODING" = "ISO-8859-1";
> 
> This is only needed when there are multiple localizable strings that are the same in English, but not necessarily the same in other languages.

I wasn’t suggesting that it was needed, I was suggesting that it would aid in localization.

[Alexey Proskuryakov]

> I was referring to the particular comment in your patch.

I didn't explain where the confusion was. It's perfectly clear how to localize this string, but testing the localization is a challenge, because people expect to see its effect on Mac.