Bug 110710 - [chromium] add content shell specific TestExpectations
Summary: [chromium] add content shell specific TestExpectations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-24 03:43 PST by jochen
Modified: 2013-02-26 03:24 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2013-02-24 03:45 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (4.97 KB, patch)
2013-02-26 00:52 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-24 03:43:31 PST 
[chromium] add content shell specific TestExpectations
Comment 1 jochen 2013-02-24 03:45:22 PST 
Created attachment 189968 [details]
Patch
Comment 2 Dirk Pranke 2013-02-25 11:45:31 PST 
Comment on attachment 189968 [details]
Patch

Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now.
Comment 3 jochen 2013-02-25 12:33:32 PST 
(In reply to comment #2)
> (From update of attachment 189968 [details])
> Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now.

If we ever do that, it'll be temporary until DRT is gone.

What should I name the file in platform/chromium?
Comment 4 Dirk Pranke 2013-02-25 12:35:59 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 189968 [details] [details])
> > Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now.
> 
> If we ever do that, it'll be temporary until DRT is gone.
> 
> What should I name the file in platform/chromium?

No strong leaning ... ContentShellTestExpectations or something webkit-y like that?
Comment 5 jochen 2013-02-26 00:52:44 PST 
Created attachment 190227 [details]
Patch
Comment 6 Eric Seidel (no email) 2013-02-26 01:04:27 PST 
Comment on attachment 190227 [details]
Patch

This is sadness.  I hope this is temporary.
Comment 7 jochen 2013-02-26 01:07:26 PST 
(In reply to comment #6)
> (From update of attachment 190227 [details])
> This is sadness.  I hope this is temporary.

Yes.

I'm preparing to switch from DRT to content_shell, and I wanted to have a temp location to dump the new expectations, so people can easily see what happens when we switch.
Comment 8 Eric Seidel (no email) 2013-02-26 01:11:46 PST 
Comment on attachment 190227 [details]
Patch

Where are these even read?  Does NRWT support this?
Comment 9 jochen 2013-02-26 01:14:14 PST 
they currently live in src/content/shell/layout_tests/TestExpectations. NRWT has a flag --additional-expectations-files which is used on the WebKit (Content Shell) * builders
Comment 10 Eric Seidel (no email) 2013-02-26 01:16:44 PST 
Comment on attachment 190227 [details]
Patch

I see.  OK.  Why so many unexpected passes?
Comment 11 jochen 2013-02-26 01:22:31 PST 
(In reply to comment #10)
> (From update of attachment 190227 [details])
> I see.  OK.  Why so many unexpected passes?

I think it's mainly because of differences in the implementation of TestShell and ContentShell where we didn't bother to get a "real" implementation for TestShell
Comment 12 WebKit Review Bot 2013-02-26 03:24:36 PST 
Comment on attachment 190227 [details]
Patch

Clearing flags on attachment: 190227

Committed r144034: <http://trac.webkit.org/changeset/144034>
Comment 13 WebKit Review Bot 2013-02-26 03:24:40 PST 
All reviewed patches have been landed.  Closing bug.