RESOLVED FIXED110710
[chromium] add content shell specific TestExpectations 
https://bugs.webkit.org/show_bug.cgi?id=110710
Summary [chromium] add content shell specific TestExpectations
jochen
Reported 2013-02-24 03:43:31 PST
[chromium] add content shell specific TestExpectations
Attachments
Patch (4.99 KB, patch)
2013-02-24 03:45 PST, jochen 		no flags
DetailsFormatted DiffDiff
Patch (4.97 KB, patch)
2013-02-26 00:52 PST, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2013-02-24 03:45:22 PST
Created attachment 189968 [details] Patch
Dirk Pranke
Comment 2 2013-02-25 11:45:31 PST
Comment on attachment 189968 [details] Patch Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now.
jochen
Comment 3 2013-02-25 12:33:32 PST
(In reply to comment #2) > (From update of attachment 189968 [details]) > Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now. If we ever do that, it'll be temporary until DRT is gone. What should I name the file in platform/chromium?
Dirk Pranke
Comment 4 2013-02-25 12:35:59 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 189968 [details] [details]) > > Do we expect to ever create content-shell specific baselines? If not, I'd probably be more inclined to put this in a separate expectations file in platform/chromium for now. > > If we ever do that, it'll be temporary until DRT is gone. > > What should I name the file in platform/chromium? No strong leaning ... ContentShellTestExpectations or something webkit-y like that?
jochen
Comment 5 2013-02-26 00:52:44 PST
Created attachment 190227 [details] Patch
Eric Seidel (no email)
Comment 6 2013-02-26 01:04:27 PST
Comment on attachment 190227 [details] Patch This is sadness. I hope this is temporary.
jochen
Comment 7 2013-02-26 01:07:26 PST
(In reply to comment #6) > (From update of attachment 190227 [details]) > This is sadness. I hope this is temporary. Yes. I'm preparing to switch from DRT to content_shell, and I wanted to have a temp location to dump the new expectations, so people can easily see what happens when we switch.
Eric Seidel (no email)
Comment 8 2013-02-26 01:11:46 PST
Comment on attachment 190227 [details] Patch Where are these even read? Does NRWT support this?
jochen
Comment 9 2013-02-26 01:14:14 PST
they currently live in src/content/shell/layout_tests/TestExpectations. NRWT has a flag --additional-expectations-files which is used on the WebKit (Content Shell) * builders
Eric Seidel (no email)
Comment 10 2013-02-26 01:16:44 PST
Comment on attachment 190227 [details] Patch I see. OK. Why so many unexpected passes?
jochen
Comment 11 2013-02-26 01:22:31 PST
(In reply to comment #10) > (From update of attachment 190227 [details]) > I see. OK. Why so many unexpected passes? I think it's mainly because of differences in the implementation of TestShell and ContentShell where we didn't bother to get a "real" implementation for TestShell
WebKit Review Bot
Comment 12 2013-02-26 03:24:36 PST
Comment on attachment 190227 [details] Patch Clearing flags on attachment: 190227 Committed r144034: <http://trac.webkit.org/changeset/144034>
WebKit Review Bot
Comment 13 2013-02-26 03:24:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.