[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
Created attachment 189948 [details] Patch
Attachment 189948 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/GtkVersioning.c']" exit_code: 1 Source/WebCore/platform/gtk/GtkVersioning.c:21: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 189949 [details] Patch
Created attachment 189977 [details] Patch
Comment on attachment 189977 [details] Patch Thanks for the fix. Minor nit is that usually there is no blank line after the first include.
Committed r143869: <http://trac.webkit.org/changeset/143869>
Nice sed trick I used to fix the nit: sed -i 'N;N;s/#include "autotoolsconfig.h"\n\n/#include "autotoolsconfig.h"\n/' *.c