Bug 110699 - [EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
Summary: [EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-23 15:59 PST by Laszlo Gombos
Modified: 2013-02-24 13:13 PST (History)
5 users (show)

See Also:

Attachments
proposed change (1.98 KB, patch)
2013-02-23 16:27 PST, Laszlo Gombos 		kling: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
for cq (1.75 KB, patch)
2013-02-24 11:51 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2013-02-23 15:59:57 PST 
ENABLE_REGIONS seems to be incorrectly named in r129395.
Comment 1 Laszlo Gombos 2013-02-23 16:27:53 PST 
Created attachment 189944 [details]
proposed change
Comment 2 WebKit Review Bot 2013-02-24 01:48:56 PST 
Comment on attachment 189944 [details]
proposed change

Rejecting attachment 189944 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-02', 'validate-changelog', '--non-interactive', 189944, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16738236
Comment 3 Laszlo Gombos 2013-02-24 11:51:46 PST 
Created attachment 189983 [details]
for cq

I keep deleting the Reviewed By: line for some reason :-(
Comment 4 WebKit Review Bot 2013-02-24 13:13:07 PST 
Comment on attachment 189983 [details]
for cq

Clearing flags on attachment: 189983

Committed r143879: <http://trac.webkit.org/changeset/143879>
Comment 5 WebKit Review Bot 2013-02-24 13:13:11 PST 
All reviewed patches have been landed.  Closing bug.