Bug 110678 - Correct InspectorInstrumentation for background HTML parser
Summary: Correct InspectorInstrumentation for background HTML parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-02-22 18:28 PST by Tony Gentilcore
Modified: 2013-02-22 20:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.36 KB, patch)
2013-02-22 18:31 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2013-02-22 18:28:07 PST
Correct InspectorInstrumentation for background HTML parser
Comment 1 Tony Gentilcore 2013-02-22 18:31:40 PST
Created attachment 189889 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-22 19:16:25 PST
Comment on attachment 189889 [details]
Patch

Clearing flags on attachment: 189889

Committed r143828: <http://trac.webkit.org/changeset/143828>
Comment 3 WebKit Review Bot 2013-02-22 19:16:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Eric Seidel (no email) 2013-02-22 20:05:00 PST
Comment on attachment 189889 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189889&action=review

> Source/WebCore/html/parser/HTMLDocumentParser.cpp:316
> +    InspectorInstrumentationCookie cookie = InspectorInstrumentation::willWriteHTML(document(), 0, lineNumber().zeroBasedInt());

This should be trivial to fix, if we add it to the chuck struct passed from the background. :)
Comment 5 Eric Seidel (no email) 2013-02-22 20:05:11 PST
Thanks for doing this. :)