Bug 110676 – [V8] Generate xxxAttrGetterCallback()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Kentaro Hara]

This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings. This patch introduces an indirection function for xxxAttrGetter(), like this:

// For non-custom getters
Handle<Value> xxxAttrGetterCallback(...) {
  return xxxAttrGetter(...);
}

// For custom getters.
Handle<Value> xxxAttrGetterCallback(...) {
  return xxxAttrGetterCustom(...);
}

[Kentaro Hara]

Created attachment 189892 [details]
Patch

[Adam Barth]

Comment on attachment 189892 [details]
Patch

Does this have any impact on microbenchmark performance?

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 189892 [details])
> Does this have any impact on microbenchmark performance?

I couldn't observe any perf regression in Bindings/first-child.html, so I think it's OK.

[WebKit Review Bot]

Comment on attachment 189892 [details]
Patch

Rejecting attachment 189892 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 189892, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
8TestObj.cpp
patching file Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
Hunk #5 FAILED at 163.
1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp.rej
patching file Source/WebCore/bindings/scripts/test/V8/V8TestTypedefs.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16723963

[Kentaro Hara]

Committed r143856: <http://trac.webkit.org/changeset/143856>