Bug 110665 - ResourceRequestBase unnecessarily updates when nothing changes
Summary: ResourceRequestBase unnecessarily updates when nothing changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 17:01 PST by Alexey Proskuryakov
Modified: 2013-02-23 23:31 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (3.92 KB, patch)
2013-02-22 17:05 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-02-22 17:01:49 PST 
ResourceRequestBase likes to set m_platformRequestUpdated  to false even if nothing changed. Updating is a very expensive operation, and should be avoided as much as possible.
Comment 1 Alexey Proskuryakov 2013-02-22 17:05:31 PST 
Created attachment 189869 [details]
proposed patch
Comment 2 WebKit Review Bot 2013-02-23 23:31:01 PST 
Comment on attachment 189869 [details]
proposed patch

Clearing flags on attachment: 189869

Committed r143861: <http://trac.webkit.org/changeset/143861>
Comment 3 WebKit Review Bot 2013-02-23 23:31:04 PST 
All reviewed patches have been landed.  Closing bug.