Bug 110640 - [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
Summary: [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 14:01 PST by James Robinson
Modified: 2013-02-25 16:46 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.45 KB, patch)
2013-02-22 14:02 PST, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2013-02-22 14:01:11 PST
[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
Comment 1 James Robinson 2013-02-22 14:02:22 PST
Created attachment 189820 [details]
Patch
Comment 2 James Robinson 2013-02-22 14:03:55 PST
Comment on attachment 189820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189820&action=review

> Source/WebKit/chromium/src/WebViewImpl.cpp:-4022
> -    IntRect damagedRect(0, 0, m_size.width, m_size.height);
> -    if (!m_isAcceleratedCompositingActive && !m_suppressInvalidations)
> -        m_client->didInvalidateRect(damagedRect);

This is dead code - m_suppressInvalidations will always be true here since it's set at the top of the function.  I'm not sure how we got into this state but everything seems to be working fine.
Comment 3 WebKit Review Bot 2013-02-22 14:10:57 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adrienne Walker 2013-02-25 15:27:28 PST
Comment on attachment 189820 [details]
Patch

R=me.
Comment 5 WebKit Review Bot 2013-02-25 16:46:19 PST
Comment on attachment 189820 [details]
Patch

Clearing flags on attachment: 189820

Committed r143985: <http://trac.webkit.org/changeset/143985>
Comment 6 WebKit Review Bot 2013-02-25 16:46:22 PST
All reviewed patches have been landed.  Closing bug.