RESOLVED FIXED 110640
[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient 
https://bugs.webkit.org/show_bug.cgi?id=110640
Summary [chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWi...
James Robinson
Reported 2013-02-22 14:01:11 PST
[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
Attachments
Patch (3.45 KB, patch)
2013-02-22 14:02 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-02-22 14:02:22 PST
Created attachment 189820 [details] Patch
James Robinson
Comment 2 2013-02-22 14:03:55 PST
Comment on attachment 189820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189820&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:-4022 > - IntRect damagedRect(0, 0, m_size.width, m_size.height); > - if (!m_isAcceleratedCompositingActive && !m_suppressInvalidations) > - m_client->didInvalidateRect(damagedRect); This is dead code - m_suppressInvalidations will always be true here since it's set at the top of the function. I'm not sure how we got into this state but everything seems to be working fine.
WebKit Review Bot
Comment 3 2013-02-22 14:10:57 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adrienne Walker
Comment 4 2013-02-25 15:27:28 PST
Comment on attachment 189820 [details] Patch R=me.
WebKit Review Bot
Comment 5 2013-02-25 16:46:19 PST
Comment on attachment 189820 [details] Patch Clearing flags on attachment: 189820 Committed r143985: <http://trac.webkit.org/changeset/143985>
WebKit Review Bot
Comment 6 2013-02-25 16:46:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.