Bug 110637 - Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
Summary: Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 110724
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-02-22 13:30 PST by Adam Barth
Modified: 2013-02-25 18:38 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.80 KB, patch)
2013-02-22 13:34 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (7.79 KB, patch)
2013-02-25 12:19 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-22 13:30:25 PST
Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
Comment 1 Adam Barth 2013-02-22 13:34:07 PST
Created attachment 189815 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-22 13:43:34 PST
Comment on attachment 189815 [details]
Patch

This is fine.  We could be more sophisticated and just handle the first chunk on the main thread. :)
Comment 3 Adam Barth 2013-02-22 13:49:43 PST
That might be worth doing in general for loads since we'll get to the first byte faster.
Comment 4 WebKit Review Bot 2013-02-22 14:19:35 PST
Comment on attachment 189815 [details]
Patch

Clearing flags on attachment: 189815

Committed r143797: <http://trac.webkit.org/changeset/143797>
Comment 5 WebKit Review Bot 2013-02-22 14:19:39 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2013-02-24 23:07:58 PST
Re-opened since this is blocked by bug 110724
Comment 7 Vsevolod Vlasov 2013-02-25 02:22:00 PST
Downstream chromium content_browsertests BookmarkletTest.NonEmptyResult test was also broken by this patch.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BookmarkletTest.NonEmptyResult
Comment 8 Adam Barth 2013-02-25 12:19:13 PST
Created attachment 190102 [details]
Patch for landing
Comment 9 WebKit Review Bot 2013-02-25 18:38:09 PST
Comment on attachment 190102 [details]
Patch for landing

Clearing flags on attachment: 190102

Committed r144000: <http://trac.webkit.org/changeset/144000>
Comment 10 WebKit Review Bot 2013-02-25 18:38:12 PST
All reviewed patches have been landed.  Closing bug.