Bug 110634 - Uint8ClampedArray constructor is wrong in WorkerContext.idl
Summary: Uint8ClampedArray constructor is wrong in WorkerContext.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 13:02 PST by Kenneth Russell
Modified: 2013-02-22 14:12 PST (History)
7 users (show)

See Also:


Attachments
Patch (63.65 KB, patch)
2013-02-22 13:14 PST, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2013-02-22 13:02:30 PST
Uint8ClampedArray is incorrectly defined as Uint8ArrayConstructor in WorkerContext.idl. It should be Uint8ClampedArrayConstructor. This causes incorrect behavior when Uint8ClampedArray is used in a worker.
Comment 1 Kenneth Russell 2013-02-22 13:14:39 PST
Created attachment 189812 [details]
Patch
Comment 2 Adam Barth 2013-02-22 13:51:14 PST
Comment on attachment 189812 [details]
Patch

wow
Comment 3 Kenneth Russell 2013-02-22 14:03:13 PST
Yeah, the test is 100x larger than the fix :)
Comment 4 Adam Barth 2013-02-22 14:04:21 PST
Oh, I meant "wow" in the sense that this is a bad bug.
Comment 5 Kenneth Russell 2013-02-22 14:09:14 PST
Ah yes, that too.
Comment 6 WebKit Review Bot 2013-02-22 14:12:16 PST
Comment on attachment 189812 [details]
Patch

Clearing flags on attachment: 189812

Committed r143792: <http://trac.webkit.org/changeset/143792>
Comment 7 WebKit Review Bot 2013-02-22 14:12:19 PST
All reviewed patches have been landed.  Closing bug.