Bug 110631 - ScrollingStateTree::rootStateNode() should be null-checked since it can be null
Summary: ScrollingStateTree::rootStateNode() should be null-checked since it can be null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
: 110509 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-22 12:48 PST by Beth Dakin
Modified: 2013-02-22 13:40 PST (History)
11 users (show)

See Also:


Attachments
Patch (2.04 KB, patch)
2013-02-22 12:51 PST, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-02-22 12:48:46 PST
ScrollingStateTree::rootStateNode() can be null when you are navigating between pages. There are two places in the code that don't null-check it, and I believe that those spots are responsible for some non-reproducible crashes that we have reports of.

I believe this patch will fix https://bugs.webkit.org/show_bug.cgi?id=110509 which corresponds to <rdar://problem/12519348> and also <rdar://problem/13233090>. The offsets in those crashes do appear to be attempts at accessing setShouldUpdateScrollLayerPositionOnMainThread() and children() respectively on a null ScrollingStateNode.
Comment 1 Beth Dakin 2013-02-22 12:51:15 PST
Created attachment 189808 [details]
Patch
Comment 2 Beth Dakin 2013-02-22 13:40:06 PST
Thanks! http://trac.webkit.org/changeset/143785
Comment 3 Beth Dakin 2013-02-22 13:40:42 PST
*** Bug 110509 has been marked as a duplicate of this bug. ***